Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(RELEASE-400): adds check-data-keys task in release pipeline #720

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

feat(RELEASE-400): adds check-data-keys task in release pipeline #720

wants to merge 1 commit into from

Conversation

seanconroy2021
Copy link
Member

@seanconroy2021 seanconroy2021 commented Dec 3, 2024 •
edited
Loading

This commit adds the check-data-keys task into the release pipelines to ensure validation of required data keys.
Link

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 3, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@konflux-ci konflux-ci deleted a comment from openshift-ci bot Dec 3, 2024
@seanconroy2021 seanconroy2021 force-pushed the fbc-pipeline branch 3 times, most recently from d339fc4 to 2e89177 Compare December 3, 2024 13:29
@seanconroy2021 seanconroy2021 force-pushed the fbc-pipeline branch 8 times, most recently from 5d88a5c to d7ef3c8 Compare December 4, 2024 10:59
@seanconroy2021 seanconroy2021 changed the title feat(RELEASE-400): incorporate check-data-keys task in FBC pipeline feat(RELEASE-400): incorporate check-data-keys task in release pipeline Dec 4, 2024
@seanconroy2021 seanconroy2021 force-pushed the fbc-pipeline branch 4 times, most recently from c9ccb55 to 7ca3e22 Compare December 4, 2024 19:58
seanconroy2021
seanconroy2021 commented Dec 4, 2024
View reviewed changes
schema/dataKeys.json
@@ -49,8 +57,7 @@
},
"productName": {
"type": "string",
"description": "The product name e.g. exampleproduct ",
"pattern": "^[a-z]+$"
Copy link
Member Author

@seanconroy2021 seanconroy2021 Dec 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/workspace/data/5c52c6c8-898a-4a85-93b2-9336e6601e52/data.json::$.fbc.productName: 'testProductName' does not match '^[a-z]+$'

Just removing for time being to get E2E to pass.... I would say we can remove it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe just relax it to allow capital letters? Or modify e2e to contain lowercase in the name? That should be easy. Maybe just this here? https://github.com/konflux-ci/e2e-tests/blob/fd26460f5d0035b0bffe699513c558be8588b209/tests/release/pipelines/fbc_release.go#L347

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hit this with some of the advisory keys too. I am fine with either removing it (the pattern, not the description) or modifying like Martin said so long as it is not too restricting such that users are going to fail on this

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok so I have allowed for the pattern to have capital letters

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also get this one .fbc.productName: 'preGA-product' does not match '^[a-zA-Z]+$.' I could add in to allow hyphen or just update e2e.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Up to you. I don't know that we have the exact requirements on this field which is why I say we can just remove it, but no strong opinion

@seanconroy2021 seanconroy2021 force-pushed the fbc-pipeline branch 5 times, most recently from a7d2762 to 7c51620 Compare December 5, 2024 13:54
@seanconroy2021 seanconroy2021 force-pushed the fbc-pipeline branch 7 times, most recently from 1ab75dc to e845b07 Compare December 9, 2024 10:32
johnbieren
johnbieren previously approved these changes Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@johnbieren johnbieren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, would be nice to get Leandro's input on the fbc keys before merging

@openshift-ci openshift-ci bot added the lgtm label Dec 9, 2024
@openshift-ci openshift-ci bot removed the lgtm label Dec 9, 2024
johnbieren
johnbieren previously approved these changes Dec 9, 2024
View reviewed changes
@openshift-ci openshift-ci bot added the lgtm label Dec 9, 2024
@seanconroy2021
Copy link
Member Author

/retest

mmalina
mmalina previously approved these changes Dec 10, 2024
View reviewed changes
@openshift-ci openshift-ci bot removed the lgtm label Dec 10, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 10, 2024

New changes are detected. LGTM label has been removed.

@johnbieren
Copy link
Collaborator 

                        "lastTransitionTime": "2024-12-10T15:03:18Z",
                        "message": "the step \"reduce\" in TaskRun \"managed-gld9m-reduce-snapshot\" failed to pull the image \"\". The pod errored with the message: \"Back-off pulling image \"quay.io/enterprise-contract/ec-cli@sha256:913c7dac3d41877b01835d2e55bcd970c6cdbf4944f8176e9e3de9548642a2b4\".\"",
                        "reason": "TaskRunImagePullFailed",
                        "status": "False",
                        "type": "Succeeded"

@seanconroy2021
feat(RELEASE-400): adds check-data-keys task in release pipelines
7731284 
This commit adds the check-data-keys task into the
release pipelines to ensure validation of required data keys.

Signed-off-by: Sean Conroy <sconroy@redhat.com>
@seanconroy2021 seanconroy2021 dismissed stale reviews from johnbieren and mmalina via 7731284 December 10, 2024 15:34
@seanconroy2021
Copy link
Member Author

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnbieren johnbieren johnbieren left review comments

@mmalina mmalina mmalina left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@mmalina mmalina

@johnbieren johnbieren

Labels
ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@seanconroy2021 @johnbieren @mmalina @openshift-merge-robot